[OpenVINO]Session Options Appended After AppendExecutionProvider #23852
+35
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to make sure to honor SessionOptions API Contract
fs-eire
reviewed
Mar 1, 2025
| config_options = &session_options->config_options; | ||
| } | ||
|
|
||
| std::array<const void*, 2> configs_array = {provider_options_map, config_options}; |
There was a problem hiding this comment.
how about declare a struct type?
struct OpenVINOProviderFactoryCreateParams {
const ProviderOptions* provider_options_map;
const ConfigOptions* config_options;
};This would be much easier to read
There was a problem hiding this comment.
Earlier we had a similar structure but looking at this code, https://github.com/microsoft/onnxruntime/blob/99c51a326e0ff54a56e7b194204d459932084408/onnxruntime/core/session/provider_bridge_ort.cc#L1992C2-L1992C3
I desired to have consistency.
fs-eire
reviewed
Mar 1, 2025
onnxruntime/core/providers/openvino/openvino_provider_factory.cc
Outdated
Show resolved
Hide resolved
fs-eire
reviewed
Mar 1, 2025
onnxruntime/core/providers/openvino/openvino_provider_factory.cc
Outdated
Show resolved
Hide resolved
fs-eire
reviewed
Mar 1, 2025
sfatimar
changed the title
…runtime into sahar/session_options
|
@fs-eire Please comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To honor SessionOption API Contract the ordering of AddConfigOption and AppendExecutionProvider_OpenVINO should not matter. This PR is fixing that issue
Motivation and Context
This PR fixes a regression happened during last PR in ordering of SessionOptions.